sqlx-core pools optionally immediately return ConnectionRefused errors instead of hanging and returning PoolTimedOut #3929
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
made it optional with the |
alkeryn
force-pushed
the
pool_connection_refused_fix
branch
from
01373ef to
3e77113
Compare
alkeryn
changed the title
alkeryn
changed the title
it is now possible to set return_con_refused to true so that connection refused errors are immediately returned instead of hanging until the timeout and returning a PoolTimedOut error
alkeryn
force-pushed
the
pool_connection_refused_fix
branch
from
3e77113 to
1583df2
Compare
|
hey @abonander could this get a review ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of hanging until the timeout and returning a PoolTimedOut error
Does your PR solve an issue?
fixes #744
this also would fix a bunch of duplicate / similar issues, didn't take the time to list them all.
Is this a breaking change?
following the last commit, no, it's a new options when creating the pool.
as mentioned by my comment in the issue :
if your db goes down you don't want users to have to wait a few seconds to get an error when they could get some 500 error immediately.
i understand that the pr may need some edits, but i wanted this issue to get some attention.