[postgres] Display line number in error message #4118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
This makes Postgres errors include the line number for easier debugging. This makes the error output similar to what MySQL and SQLite do by default.
Is this a breaking change?
While changing the display of an error could in theory break weird workflows, it seems quite unlikely. Worst case people who have already implemented workarounds will get two line numbers.
Alternatives Considered
An alternative would be to print the position rather than the line number. This could maybe be combined with the macros to put an error only under the relevant line, but as an isolated change a line number is more human readable, and more in line with what the other databases implement.