Skip to content

feat: add Connection method to RedisStoreBuilder for external Redis connections #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gor-st
Copy link

@gor-st gor-st commented Aug 2, 2025

Adds Connection() method to RedisStoreBuilder<T> to accept pre-configured IConnectionMultiplexer instances. This enables Azure AAD authentication and other advanced connection scenarios while maintaining backward compatibility.

Changes:

  • Added Connection() method to RedisStoreBuilder
  • Updated constructors to accept IConnectionMultiplexer instead of ConfigurationOptions
  • Added GetOrCreateConnection() helper method
  • Updated unit tests

Fixes #146

…onnections

- Add Connection() method to accept pre-configured IConnectionMultiplexer
- Support Azure AAD authentication and other advanced connection scenarios
- Maintain backward compatibility with existing configuration methods
- Update constructors to accept IConnectionMultiplexer instead of ConfigurationOptions
- Add comprehensive unit tests for new functionality
- Refactor connection creation logic to support both external and configured connections

Fixes launchdarkly#146
@gor-st gor-st changed the title Add Connection method to RedisStoreBuilder for external Redis connections feat: add Connection method to RedisStoreBuilder for external Redis connections Aug 2, 2025
@gor-st gor-st marked this pull request as ready for review August 2, 2025 18:11
@gor-st gor-st requested a review from a team as a code owner August 2, 2025 18:11
@louis-launchdarkly
Copy link
Contributor

Hello @gor-st,

Thank you for your contribution. We will look into this change soon once the .NET engineer has more time.

Louis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for Pre-configured Redis Connections in Data Store
2 participants