fix(modal): increase modal close button style specificity #1776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a bundled CSS file were to be loaded after the Modal CSS file, and that bundled file also includes the base styles for
Button
, it will cause the.closeButton
of theModal
to lose itsmargin-left
style declaration, which is what pushes the modal close button to the right of the header.Given that neither
.headerMain
or.closeButton
are user-configurable, this nests those classes under.header
to increase the specificity of the.closeButton
'smargin-left
declaration to be higher than that of the base.Button
styles.Screenshots (if appropriate):
Testing approaches