Skip to content

Conversation

@ari-launchdarkly
Copy link
Contributor

@ari-launchdarkly ari-launchdarkly commented Oct 27, 2025

Summary

the Snippet component has a lot of global CSS applications that can override other classes. This might cause issues to external consumers of the snippet component. As such, we'll scale back this implementation until we can come up with a larger-scale solution

Screenshots (if appropriate):

Testing approaches


Related Jira issue: REL-10404: Remove Snippet from Launchpad

@ari-launchdarkly ari-launchdarkly requested a review from a team as a code owner October 27, 2025 21:26
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

🦋 Changeset detected

Latest commit: dcd2d28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@launchpad-ui/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 27, 2025

yarn add https://pkg.pr.new/@launchpad-ui/[email protected]
yarn add https://pkg.pr.new/@launchpad-ui/[email protected]
yarn add https://pkg.pr.new/@launchpad-ui/[email protected]

commit: dcd2d28

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

Size Change: -67.7 kB (-11.26%) 👏

Total Size: 534 kB

Filename Size Change
packages/components/dist/index.es.js 19.6 kB -33.3 kB (-62.94%) 🏆
packages/components/dist/index.js 20.5 kB -33.2 kB (-61.84%) 🏆
packages/components/dist/style.css 8.39 kB -1.26 kB (-13.02%) 👏
ℹ️ View Unchanged
Filename Size
apps/vscode/dist/client.js 111 kB
apps/vscode/dist/server.js 261 kB
packages/box/dist/index.es.js 7.26 kB
packages/box/dist/index.js 7.82 kB
packages/box/dist/style.css 2.67 kB
packages/button/dist/index.es.js 1.89 kB
packages/button/dist/index.js 2.32 kB
packages/button/dist/style.css 3 kB
packages/core/dist/index.es.js 512 B
packages/core/dist/index.js 1.27 kB
packages/drawer/dist/index.es.js 1.76 kB
packages/drawer/dist/index.js 2.22 kB
packages/drawer/dist/style.css 497 B
packages/dropdown/dist/index.es.js 1.15 kB
packages/dropdown/dist/index.js 1.59 kB
packages/filter/dist/index.es.js 2.23 kB
packages/filter/dist/index.js 2.68 kB
packages/filter/dist/style.css 881 B
packages/focus-trap/dist/index.es.js 418 B
packages/focus-trap/dist/index.js 852 B
packages/form/dist/index.es.js 4.25 kB
packages/form/dist/index.js 4.73 kB
packages/form/dist/style.css 2.21 kB
packages/icons/dist/index.es.js 2.81 kB
packages/icons/dist/index.js 3.24 kB
packages/icons/dist/style.css 532 B
packages/menu/dist/index.es.js 3.69 kB
packages/menu/dist/index.js 4.16 kB
packages/menu/dist/style.css 872 B
packages/modal/dist/index.es.js 3.08 kB
packages/modal/dist/index.js 3.55 kB
packages/modal/dist/style.css 903 B
packages/navigation/dist/index.es.js 2.75 kB
packages/navigation/dist/index.js 3.21 kB
packages/navigation/dist/style.css 874 B
packages/overlay/dist/index.es.js 1.02 kB
packages/overlay/dist/index.js 1.42 kB
packages/popover/dist/index.es.js 3.01 kB
packages/popover/dist/index.js 3.43 kB
packages/popover/dist/style.css 529 B
packages/portal/dist/index.es.js 420 B
packages/portal/dist/index.js 835 B
packages/table/dist/index.es.js 1.01 kB
packages/table/dist/index.js 1.44 kB
packages/table/dist/style.css 700 B
packages/tokens/dist/fonts.css 183 B
packages/tokens/dist/index.css 1.47 kB
packages/tokens/dist/index.es.js 3.07 kB
packages/tokens/dist/index.js 3.11 kB
packages/tokens/dist/media-queries.css 113 B
packages/tokens/dist/themes.css 2.27 kB
packages/tooltip/dist/index.es.js 598 B
packages/tooltip/dist/index.js 1.02 kB
packages/tooltip/dist/style.css 337 B
packages/vars/dist/index.es.js 2.66 kB
packages/vars/dist/index.js 2.66 kB

compressed-size-action

@zmdavis
Copy link

zmdavis commented Oct 27, 2025

Oh wait, do we need to remove the dependency on prismjs?

@ari-launchdarkly ari-launchdarkly force-pushed the ari-launchdarkly/REL-10404-remove-snippet branch from 1fb57d3 to dcd2d28 Compare October 27, 2025 21:28
@ari-launchdarkly
Copy link
Contributor Author

Oh wait, do we need to remove the dependency on prismjs?

@zmdavis ya, I reset head and squashed it in.

@ari-launchdarkly ari-launchdarkly merged commit a3cd616 into main Oct 27, 2025
16 of 17 checks passed
@ari-launchdarkly ari-launchdarkly deleted the ari-launchdarkly/REL-10404-remove-snippet branch October 27, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants