-
Couldn't load subscription status.
- Fork 9
chore(components): remove Snippet from launchpad #1807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(components): remove Snippet from launchpad #1807
Conversation
…snippets work and apply styles
🦋 Changeset detectedLatest commit: dcd2d28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
Size Change: -67.7 kB (-11.26%) 👏 Total Size: 534 kB
ℹ️ View Unchanged
|
|
Oh wait, do we need to remove the dependency on |
1fb57d3 to
dcd2d28
Compare
@zmdavis ya, I reset head and squashed it in. |
Summary
the
Snippetcomponent has a lot of global CSS applications that can override other classes. This might cause issues to external consumers of thesnippetcomponent. As such, we'll scale back this implementation until we can come up with a larger-scale solutionScreenshots (if appropriate):
Testing approaches
Related Jira issue: REL-10404: Remove Snippet from Launchpad