-
Notifications
You must be signed in to change notification settings - Fork 54
Added some books and resources #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
glyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these suggestions. Please see my review comments.
|
@glyn I have made the changes. I also sorted the unofficial book list alphabetically. I kept that as a separate commit so that the git history is cleaner. |
glyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more italics need adding.
|
Did the changes @glyn |
glyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another alphanumeric ordering issue.
Shall we get the current set of changes correct and merged and leave others for a future PR?
glyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. For future reference, I would prefer PR scope to be stable after submission. If you find changes, other than response to my review, you'd like to make, please submit a separate PR. This will help me get your PRs merged quickly. The same approach applies in many projects, which is why I point it out. Cheers.
|
@glyn I apologize for the long back and forth. The convention for italics could be mentioned in the The categorization could also be made better and less confusing. Some of the books in |
Good idea. See #92.
Ok. If you are unsure, please start a discussion thread or send a draft PR. |
Please feel free to squash the commits