Skip to content

Conversation

thisismattmiller
Copy link
Member

This is an update from @RandyBarry work on Devanagari based tables.

  • Updated _devanagari_base.yml
  • Removed devanagari.yml
  • Updated dogri_devanagari.yml
  • Removed hindi_devanagari_alt.yml (Updated and renamed to hindi.yml)
  • Updated nepali_devanagari.yml
  • Updated newari_devanagari.yml
  • Updated prakrit_devanagari.yml
  • Updated rajasthani_devanagari.yml
  • Updated sanskrit_devanagari.yml
  • Updated index.yml to reflect the changes
  • Created bihari_devanagari.yml
  • Created braj_devanagari.yml
  • Created maithili_devanagari.yml
  • Created pahari_devanagari.yml

@thisismattmiller thisismattmiller requested a review from scossu August 7, 2025 16:16
Copy link
Collaborator

@scossu scossu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few non-binding comments, it can go in as it is.

- aksharamukha.romanizer.r2s_post_config
- dest_script: "Devanagari"
map:
" " : " "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RandyBarry This effectively maps the space character, which is ignored in the _ignore_base config.

No harm done, it's just redundant and we can let it go for expediency's sake.

To just have an empty map, you can also use map: {}

Or I can improve the code not to require map to be present and to be a dict.

general:
name: Bihari (Devanagari)
parents:
- _ignore_base
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RandyBarry This is redundant, as it's already included in _devanagari_base.

@scossu scossu merged commit 9c6f825 into main Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants