Skip to content

Changes to the arabic table mapping #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

thisismattmiller
Copy link
Member

Some changes @RandyBarry has made to the R2S mappings:

ah%
at%
an%
ʻāʾ%
ʻāʼ%
%ʻA
īʾah%
īʼah%
īʾat%
īʼat%
iʾā%
iʼā%
iʾ%
iʼ%
%Ā
%ā
%Aʻ
%aʻ
%A
%a
%Ī
%ʻI
%I
%i
%Ūw
%ūw
%Ū
%ū
%U
%u
ʾ%
ʼ%

@thisismattmiller thisismattmiller requested a review from scossu August 7, 2025 16:34
"al-T\u0323ab\u02BBah 9": "\u0627\u0644\u0637\u0628\u0639\u0629 9"

# Use Basic Arabic-Indic \u0660-0669
"0": "\u0660"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RandyBarry Why are independent numbers transliterated to \u66x but the ones above on lines 107-115 are left unchanged?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Randy's Response:

For Arabic, numerals, cataloging rules are complex for how to treat numerals. In areas like the title where numerals might occur they need to be in the original script but in areas like an edition statement or series volume numbering statement some languages prefer to keep western style numerals. Arabic and Chinese have this kind of exceptional treatment. That’s why you see the special numeral conversion logic for Arabic Roman-to-script.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why all the lines in the file are reported as changed, that's strange. But if it has been tested and works, I guess that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants