Skip to content

Fix a bunch of errors and deprecation for LLVM 21 #4950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 7, 2025
Merged

Fix a bunch of errors and deprecation for LLVM 21 #4950

merged 9 commits into from
Jul 7, 2025

Conversation

thewilsonator
Copy link
Contributor

@thewilsonator thewilsonator commented Jun 8, 2025 •
edited
Loading

Best reviewed per commit.

I am unsure what the correct value to use for the llvm::LocationSize in the case we don't know the size.

There are still a bunch of deprecations from using InsertPosition e.g. from gIR->topallocapoint() instead of BasicBlock::iterators for insertion.

@thewilsonator
Copy link
Contributor Author

thewilsonator commented Jun 8, 2025 •
edited
Loading

Also it seems that CallGraphNode::removeCallEdgeFor was removed (llvm/llvm-project#127411). I'm not sure how that functionality is supposed to be replaced. llvm/llvm-project@58bc98c suggests that we should use a LazyCallGraph and use the new pass manager. I'm not sure how close we are to making that a possibility.

For now I have just copied what the old code did inline.

kubo39
kubo39 reviewed Jun 8, 2025
View reviewed changes
@thewilsonator
Copy link
Contributor Author

This should be good to go now, but please give a thorough review on llvm::LocationSize and removeCallEdgeFor commits.

@thewilsonator
Copy link
Contributor Author

Ping

@thewilsonator
Copy link
Contributor Author

I will merge this tomorrow if there are no objections.

@thewilsonator thewilsonator merged commit 46bbe8b into ldc-developers:master Jul 7, 2025
19 of 21 checks passed
kinke added a commit to kinke/ldc that referenced this pull request Jul 28, 2025
@kinke
Fix recent dynamic-compile regression
09b5f7d 
Fix the undefined `getGlobalContext()` symbol for libldc-jit.so,
showing up with CircleCI, introduced in ldc-developers#4950.
@kinke kinke mentioned this pull request Jul 28, 2025
Merged
kinke added a commit that referenced this pull request Jul 28, 2025
@kinke
Fix recent dynamic-compile regression (#4961)
0fddfc5 
Fix the undefined `getGlobalContext()` symbol for libldc-jit.so,
showing up with CircleCI, introduced in #4950.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinke kinke Awaiting requested review from kinke

@JohanEngelen JohanEngelen Awaiting requested review from JohanEngelen

1 more reviewer

@kubo39 kubo39 kubo39 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thewilsonator @kubo39