Add -lz when PHOBOS_SYSTEM_ZLIB=on and -link-defaultlib-shared #4963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some projects use the zlib C function directly and, given that those symbols are available when phobos embeds zlib (the default) and when linking the stdlib statically, the projects often don't include a `-lz` in their build settings. This omission then prevents a successful build with PHOBOS_SYSTEM_ZLIB=on and -link-defaultlib-shared. Until a permanent decision is made if those projects should change their build scripts or if the compiler should always add `-lz`, add the library anyway, to minimize breakages. This also makes the behavior consistent with gdc which also adds an unconditional `-lz` when zlib is not embedded. See-Also: ldc-developers#4742 Signed-off-by: Andrei Horodniceanu <[email protected]>
|
ping @schveiguy |
thewilsonator
approved these changes
Aug 3, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects use the zlib C function directly and, given that those symbols are available when phobos embeds zlib (the default) and when linking the stdlib statically, the projects often don't include a
-lzin their build settings. This omission then prevents a successful build with PHOBOS_SYSTEM_ZLIB=on and-link-defaultlib-shared.
Until a permanent decision is made if those projects should change their build scripts or if the compiler should always add
-lz, add the library anyway, to minimize breakages.This also makes the behavior consistent with gdc which also adds an unconditional
-lzwhen zlib is not embedded.See-Also: #4742