Inaccuracies on Http Request module #128
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Using Leaf Core, noticed that I CANT use request()->all(). Turns out that method does not exist at all. Digging inside the Leaf\Http package in Request.php reveals that there are no such function called all(), but a function called body() that does what is needed.
Other than that, the release branch of Http has overlapping functions
params()
andgetOrDefault()
that do the exact same function. The document mentions the use ofgetOrDefault
, but the main branch for Http module showed thatgetOrDefault()
was dropped in favor ofparams()
Proposed Solution
To update the documentation to reflect the actual methods in Http Module.
Additional Information
None. Hope my PR has enough info and helps.