Restore EPUB renderer height #5491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upon inspecting the EPUB renderer, it was clear the height styling was not functioning as it was originally intended. This was abundantly clear based off the positioning of the left/right buttons, not being centered. The issue appeared to originate from some alterations to the flexbox structure upwards in the DOM. By relocating a newer div wrapper used for applying a relative style, this removed the interference causing the malfunction, and restored the intended styling.
This does not address the
tagNameerror linked in the issue as it's wholly unrelated to the render issue, and possibly benign.References
fixes #5424
related to #5351
Reviewer guidance