Skip to content

Algorithm specifyable in subplugin type #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 80 commits into
base: main
Choose a base branch
from
Open

Algorithm specifyable in subplugin type #175

wants to merge 80 commits into from

Conversation

@tobiasreischmann
Copy link
Contributor

@tobiasreischmann tobiasreischmann commented May 20, 2019

In this PR we added a subplugin type for the module, which allows to specify an own algorithm implementation.

NinaHerrmann and others added 30 commits March 18, 2019 12:20
@NinaHerrmann
added sublugin type
4761bb5
@NinaHerrmann
fixed typo
140132e
@justusdieckmann
Added formelement for minsize
e03779b
@NinaHerrmann
defined subplugin interface
2a355e8
@justusdieckmann
WIP add databasefield for minsize
7839ffd
@justusdieckmann
save min into db
e29e4dc
@NinaHerrmann
added edmondskarp as subplugin
bdcac4a
@justusdieckmann
set previous min field in form
ec23141
@NinaHerrmann
changed reference in locallib to subplugin and coing style fixes in s…
3e6db5f 
…ubplugin
@NinaHerrmann
coding style fixes in subplugin edmondskarp
53425c5
@Dagefoerde
use subplugin for test
23bfd66
@Dagefoerde
cleanup imports and fields
8c1e0f6
@justusdieckmann
insert min number of participants into list of all choices table.
710f9ee
@Dagefoerde
load algorithm dynamically
5251239
@justusdieckmann
added minsize to test
2170ad8
@justusdieckmann
added optional setting
425e50f
@justusdieckmann
add column for optional field in list of all choices table
da9e112
@justusdieckmann
adjusted testcases for optional field
65e595f
@NinaHerrmann
Add fordfulkersonkoegel algorithm
cb77a28
@NinaHerrmann
remove reference to obsolete algo file
595a9a9
@Dagefoerde
fix PHPCS in new files
2a6131a
@Dagefoerde
Add some further style fixes
2e71639
@Dagefoerde
Merge branch 'feature/subplugin' into projekttage
c321e16
@justusdieckmann
Fix behat tests by adding minsize and optional fields to choices
e754a0d
@Dagefoerde
Add tests for subplugin management
1c7674f
@Dagefoerde
Use gte instead of gt
0530be0
@justusdieckmann
added optional support to behat steps
6ae7345
@NinaHerrmann
added minsize checkbox
b44f1a1
@NinaHerrmann
added optional checkbox
ae36c39
@justusdieckmann
testing checkbox for optional setting
a588984
NinaHerrmann and others added 30 commits March 19, 2019 14:41
@NinaHerrmann
Form: disable depending on supported features
0c81ada
@NinaHerrmann
Form: send algorithm name and disable does not work.
9ec259f
@NinaHerrmann
algorithms: verify that supported_features return correct structure
a2e5cf6
@NinaHerrmann
form: use local constant instead of global one
0a4a566
@NinaHerrmann
form: validate choice of algorithm
8e76b9e
@NinaHerrmann
db: add field for persisting selected algorithm
3d63020 
default, esp. for migrations: edmondskarp
@NinaHerrmann
tests: add new instance config fields
c20d863
@NinaHerrmann
test: containsOnlyInstancesOf does not work well
8b37b97
@NinaHerrmann
form: set first algorithm as default
6afc49b
@NinaHerrmann
fix code style
d55b2ff
@NinaHerrmann
test: fix copy-paste problem in tests of new fields
44e05d3
@NinaHerrmann
Merge branch 'feature/algorithmselect' into projekttage
3e4b306
@justusdieckmann
Add table for logging
5a69529
@justusdieckmann
Add persistent for execution_log
056aa17
@justusdieckmann
skeleton for appending log and subplugin name abstract function
c164e84
@justusdieckmann
started append to log function
0c7dddb
@justusdieckmann
Passing and saving ratingallocate to algorithm in constructor method
2ef6284
@justusdieckmann
generated ratingallocate dummy instance for tests
7e86d0f
@justusdieckmann
Added getter for ratingallocateid
473be27
@justusdieckmann
Test: created initial data for logging
7795132
@justusdieckmann
Test: added testclass for algorithm
d5fd0b8
@justusdieckmann
Test: finished testcase creation for append_to_log
38a3334
@justusdieckmann
CodeStyle fixes
434ef91
@justusdieckmann
Added cutom error message for persistent class
fba4249
@justusdieckmann
Reordered savepoints in upgrade.php
28d6759
@justusdieckmann
implemented get_supported_features() in algorithm_testable
30107d7
@justusdieckmann
bugfix missing parameter for get_instance()
ba9d4a5
@justusdieckmann
remove generating ratingallocate instance because not necessary
37150e2
@justusdieckmann
Merge pull request #170 from learnweb/feature/logs
53b4779
@justusdieckmann
Include Moodle36 in .travis.yml
379255e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tobiasreischmann @NinaHerrmann @justusdieckmann @Dagefoerde