Skip to content

Conversation

@ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented Nov 27, 2025

New life for #41 (opened in Nov 2022 and abandoned since)

TODO:


The current version is rendered here: https://ulysses4ever.github.io/learnyouahaskell.github.io/chapters.html Note for @pierluc-codes : I had to change the repository I worked from (it used to be ulysses4ever/learnyouahaskell-md) because I cant open pull requests from non-forks.

Gregory Cox and others added 30 commits March 21, 2023 03:25
Signed-off-by: Artem Pelenitsyn <[email protected]>
@pierluc-codes
Copy link
Collaborator

pierluc-codes commented Dec 4, 2025

@ulysses4ever First thank a lot for adding the GitHub workflow, it helped a lot in this instance.

I brought all the textual change. There were few instance where the textual change was wrong so I took the liberty to update it. Feel free to adjust.

Let me know if you need more help!

@ulysses4ever
Copy link
Collaborator Author

@pierluc-codes terrific, thank you! (and sorry I wasn't around this week: stuff happens...).

I'll try to review the textual changes by the end of the week. I'm pretty sure, they should be fine!

In the meantime, we still should make sure styles are reasonable. In this comment you noticed several things, which aren't too bad, but the way the error message is formatted, probably needs some thought. Do you want to try to work on this front more? I see two options: (1) try to eyeball the text more and make a list of all noticeable styling changes; (2) try to fix some of these changes by updating CSS / MD / the way HTML is produced so that we have a better match with the original. THe second one is obviously more involved, so it's okay to take the first one or none at all. I hope to get to this by the end of week as well...

@pierluc-codes
Copy link
Collaborator

@ulysses4ever I eyeballed the doc and I think we are good. I did some correction here and there.

There is still a minor difference related to image size but to be honest I like the bigger images ;)

I would like to note that migration also fixed few mistake that were in the original HTML. Very cool.

@ulysses4ever
Copy link
Collaborator Author

ulysses4ever commented Dec 6, 2025

Terrific! There are two big items on the list left (at least):

  • integrate CSS changes from Make CSS responsive to improve mobile layout #64 so that we have a decent mobile view

  • nuke old html and the generated files. This is not completely trivial because the generate.sh script starts failing if you simply remove that stuff. I need to understand better how the script works before I can act on this item.

@pierluc-codes
Copy link
Collaborator

@ulysses4ever I will be busy this week so I won't be able to push this forward for at least the next week. I can make time if you need a review on something.

@ulysses4ever
Copy link
Collaborator Author

@pierluc-codes sounds good. I'll do my best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants