-
-
Notifications
You must be signed in to change notification settings - Fork 232
Adds a new bookmark package. #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a new bookmark package. #2006
Conversation
Bookmarks are stored file paths, possibly with a location, which enables the user to quickly visit files which are often needed. Bookmark information are kept in-memory, the user has to use the commands BOOKMARK-LOAD and BOOKMARK-SAVE manually to persist bookmark information. The command BOOKMARK-SET can be used to create a new bookmark for the current buffer with the current cursor position. To go to the location of a previously created bookmark, the command BOOKMARK-JUMP can be used. More commands are available to manage bookmarks, see the exported symbols from the package.
|
✅ Code Contractor Validation: PASSED 📚 About Code ContractorDeclarative Code Standards That Learn and Improve Define domain-specific validation rules in YAML. Want this for your repo? |
|
This is great, thank you! minor feedback, what if delete-all prompted for user y/n confirmation? "Do you want to delete [n] bookmarks?" LGTM and I will merge anyways. |
|
Sure thing, added. |
|
yes, I think it's good to be consistent in naming and rename it now. |
|
Done. Let me know if there is anything else I should do right now. |
|
Thank you! |
As requested, adds my bookmark package to core.
See the description of the package for more information.
For now, I decided to not name the package
lem-bookmark. It seems this is the naming convention for internal packages, but I didn't want to break users of the package, which might already have it configured. If you would like me to change it, please tell me, I have no strong feelings about it. If you do change it yourself, please also update the documentation, which points to(find-package "BOOKMARK").I decided to not load/save bookmarks automatically. It should be easy enough for a user to add a hook to their config if they wish to do so:
Not sure if there is a hook for shutdown? I personally would prefer bookmarks not to be saved automatically, since I usually also add temporary bookmarks while working with a bigger project and wouldn't want them to be saved automatically. If you want to change this behaviour in the future, please think about adding a configuration variable for saving.
I didn't test the integration thoroughly. Building lem from main worked for me, bookmarks got loaded and I could jump to them.
I don't care about ownership and gladly give up all rights so this package can be easily contributed to the core.