Skip to content

For set functions - Cast char* to const char*, resolve warning: ISO C++ #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

For set functions - Cast char* to const char*, resolve warning: ISO C++ #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd2e7e3
Update set char values to use const char
LeeNX Aug 12, 2025
b7473bd
just some formatting
LeeNX Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions BleGamepadConfiguration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ BleGamepadConfiguration::BleGamepadConfiguration() : _controllerType(CONTROLLER_
_enableOutputReport(false),
_enableNordicUARTService(false),
_outputReportLength(64),
_transmitPowerLevel(9)
_transmitPowerLevel(9)
{
}

Expand Down Expand Up @@ -206,11 +206,11 @@ void BleGamepadConfiguration::setSimulationMin(int16_t value) { _simulationMin =
void BleGamepadConfiguration::setSimulationMax(int16_t value) { _simulationMax = value; }
void BleGamepadConfiguration::setMotionMin(int16_t value) { _motionMin = value; }
void BleGamepadConfiguration::setMotionMax(int16_t value) { _motionMax = value; }
void BleGamepadConfiguration::setModelNumber(char *value) { _modelNumber = value; }
void BleGamepadConfiguration::setSoftwareRevision(char *value) { _softwareRevision = value; }
void BleGamepadConfiguration::setSerialNumber(char *value) { _serialNumber = value; }
void BleGamepadConfiguration::setFirmwareRevision(char *value) { _firmwareRevision = value; }
void BleGamepadConfiguration::setHardwareRevision(char *value) { _hardwareRevision = value; }
void BleGamepadConfiguration::setModelNumber(const char *value) { _modelNumber = value; }
void BleGamepadConfiguration::setSoftwareRevision(const char *value) { _softwareRevision = value; }
void BleGamepadConfiguration::setSerialNumber(const char *value) { _serialNumber = value; }
void BleGamepadConfiguration::setFirmwareRevision(const char *value) { _firmwareRevision = value; }
void BleGamepadConfiguration::setHardwareRevision(const char *value) { _hardwareRevision = value; }
void BleGamepadConfiguration::setEnableOutputReport(bool value) { _enableOutputReport = value; }
void BleGamepadConfiguration::setEnableNordicUARTService(bool value) { _enableNordicUARTService = value; }
void BleGamepadConfiguration::setOutputReportLength(uint16_t value) { _outputReportLength = value; }
Expand Down
16 changes: 8 additions & 8 deletions BleGamepadConfiguration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ class BleGamepadConfiguration
bool _enableOutputReport;
bool _enableNordicUARTService;
uint16_t _outputReportLength;
int8_t _transmitPowerLevel;
int8_t _transmitPowerLevel;


public:
Expand Down Expand Up @@ -299,7 +299,7 @@ class BleGamepadConfiguration
bool getEnableOutputReport();
bool getEnableNordicUARTService();
uint16_t getOutputReportLength();
int8_t getTXPowerLevel();
int8_t getTXPowerLevel();

void setControllerType(uint8_t controllerType);
void setAutoReport(bool value);
Expand Down Expand Up @@ -341,15 +341,15 @@ class BleGamepadConfiguration
void setSimulationMax(int16_t value);
void setMotionMin(int16_t value);
void setMotionMax(int16_t value);
void setModelNumber(char *value);
void setSoftwareRevision(char *value);
void setSerialNumber(char *value);
void setFirmwareRevision(char *value);
void setHardwareRevision(char *value);
void setModelNumber(const char *value);
void setSoftwareRevision(const char *value);
void setSerialNumber(const char *value);
void setFirmwareRevision(const char *value);
void setHardwareRevision(const char *value);
void setEnableOutputReport(bool value);
void setEnableNordicUARTService(bool value);
void setOutputReportLength(uint16_t value);
void setTXPowerLevel(int8_t value);
void setTXPowerLevel(int8_t value);
};

#endif