Fixed invalid custom scopes #203
Conversation
leonardoanalista
left a comment
leonardoanalista
left a comment
There was a problem hiding this comment.
Is this Pr still needed after we merged #201 ?
|
yes. thx. |
|
still have this problem~ |
| } | ||
| ``` | ||
| * **allowCustomScopes**: {boolean, default false}: adds the option `custom` to scope selection so you can still type a scope if you need. | ||
| * **allowEmptyScopes**: {boolean, default false}: allow non-selection or not to fill in the scopes. |
There was a problem hiding this comment.
I think allowEmptyScopes default should be true because it makes it easier for people to use this tool. What are your thoughts?
There was a problem hiding this comment.
If we make allowEmptyScopes default true, would that be a breaking change? No problems if so, we just need to make the commit text have:
BREAKING CHANGES:
- describe the breaking change
- steps to upgrade
| } | ||
| return false; // no breaking changes allowed unless specifed | ||
| ); | ||
| // no breaking changes allowed unless specifed |
There was a problem hiding this comment.
We may not need this comment anymore with the direct function return.
| }; | ||
|
|
||
| const addScope = (scope, config) => { | ||
| const addScope = (scope, customScope, config) => { |
There was a problem hiding this comment.
we could even consider calling this addScopeIfNeeded
@w-t-w |
|
why my scope cat working?
|
|
invalid custom scopes, Maybe inquirer filterIfRunnable function. look #212 |
|
Is it difficult to solve the problem that my custom scope cannot be entered? Why hasn't it been fixed for such a long time? 🥲 |
|
Same problem. I cannot enter my custom scope: [email protected], [email protected]
>>> Using cz-customizable config specified in your package.json: /../cz.config.cjs
All lines except first will be wrapped after 100 characters.
? Select the type of change that you're committing: ✨ feat: A new feature
? (optional) Specify a scope (e.g. apps-web, shared-ui-core): custom
? Write a SHORT, IMPERATIVE tense description of the change:
resolve PgClient config type error
? Provide a LONGER description of the change (optional):
###--------------------------------------------------------###
feat(custom): resolve PgClient config type error
###--------------------------------------------------------###
? Are you sure you want to proceed with the commit above? Abort commit |
|
It's been 3 years can we either remove custom scope or merge this commit. |
8 participants
No description provided.