Standardize ScopedFuture::new_untracked like untrack() and untrack_with_diagnostics() #4269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScopedFuture::new_untrackedto not emit diagnostics, in line withsubscriber::untrackScopedFuture::new_untracked_with_diagnostics, to matchsubscriber::untrack_with_diagnosticsArcAsyncDerived::new_with_manual_dependenciesto useScopedFuture::new_untracked_with_diagnostics, as this one we want diagnostics.ScopedFuture::new_untrackedis inActionusage, which is left unchanged, thereby disabling diagnostics, which are not needed in this context.untrackto the sync part ofActions to disable diagnostics there tooIn case there's some confusion about why this is useful:
Having these diagnostics in action calls does not provide any value, a user is acutely aware that an action is something manually "dispatched". By disabling the warning, thereby it no longer being an error to use e.g.
.get()inside an action, logic and getters that might contain signals and also be used in theview!{}/Effects, can be extracted into reusable functions, and not produce confusing warnings when used from actions.