Small fixes and improvements #18
Conversation
Cargo.lock
Outdated
There was a problem hiding this comment.
This is not a library, it's an application starter template. Including the lockfile is helpful because it ensures that the template will always build correctly, even if a dependency breaks in a later version. Note that the Cargo team has recommended committing Cargo.lock by default, even for libraries, for a couple years.
Cargo.nightly.toml
Outdated
There was a problem hiding this comment.
These changes seem a bit opinionated for a template. I would leave them as is and let people tweak the settings if they want to.
Cargo.stable.toml
Outdated
There was a problem hiding this comment.
(See same comments on the nightly file)
Trunk.toml
Outdated
| @@ -14,17 +20,19 @@ filehash = true | |||
| # Whether to inject scripts (and module preloads) into the finalized output. | |||
| inject_scripts = true | |||
| # Run without network access | |||
| # offline = false | |||
| offline = false | |||
There was a problem hiding this comment.
The changes to add additional features to this file also (inadvertently?) uncommented a bunch of settings that were previously commented out.
cargo-generate.toml
Outdated
| @@ -1,16 +1,16 @@ | |||
| [template] | |||
| ignore = ["Cargo.lock", "switch_nightly_stable.rhai"] | |||
| ignore = ["switch_nightly_stable.rhai"] | |||
There was a problem hiding this comment.
Should be restored with lockfile
|
You are right, I put the For the dev profile optimizations in |
This PR adresses the following issues:
cargo-generatecommand in README.md was pointing to a non-existent reporust-analyzer.toml, which should work with more IDEsCargo.lock, as this file should not be part of a library