Fix regexp warning Issue #48 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the \w regexp character already includes the underscore, so the underscore is redundant, generating the warnings. The fix was to remove the underscore. It would be nice to verify this manually on a structure dump with some of the statements that related to waht's modified here.
|
As I said - not a regex guy at all. Looks like the tests passed, so that's good enough for me! |
|
@ghiculescu Let's include this in the upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the \w regexp character already includes the underscore, so the underscore is redundant, generating the warnings.
The fix was to remove the underscore. It would be nice to verify this manually on a structure dump with some of the statements that related to waht's modified here.