catch throw object from validator and abi changes #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoKengi
force-pushed
the
Kenny-catch_throw
branch
from
5aad98f to
6a5ed3b
Compare
Mchan2003
reviewed
Dec 12, 2025
Collaborator
Mchan2003
left a comment
Mchan2003
left a comment
There was a problem hiding this comment.
Looks good. I'm assuming the commented stuff is for later. If you haven't or was planning in the next pr, add the methods of validator_catch to validator class
include/validator_catch.hpp
Outdated
Comment on lines
27
to
31
| // struct ThrowCatchMatch | ||
| // { | ||
| // symbol_s thrown; // RTTI symbol for the thrown type | ||
| // std::vector<const CatchRecord*> handlers; // matching catch handlers | ||
| // }; |
Collaborator
There was a problem hiding this comment.
Is there a reason a lot of the code is commented out?
Contributor
Author
There was a problem hiding this comment.
its commented out because it wouldnt build properly since a lot of it is connected to ur validator branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be able to catch the thrown object from Michael's branch and made some changes to ABI