Merge what left of old branch #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mchan2003
requested changes
Dec 14, 2025
Collaborator
Mchan2003
left a comment
Mchan2003
left a comment
There was a problem hiding this comment.
Overall looks good. Just have a nit.
src/validator.cpp
Outdated
Comment on lines
201
to
206
| bool Validator::thrown_functions(std::string_view func_name) | ||
| { | ||
| auto thrown_opt = find_typeinfo(func_name); | ||
| return thrown_opt.has_value() && !thrown_opt->empty(); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
NIT: is this just checking if a function has throws? If it is. change name to reflect that.
Mchan2003
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.