Check peer's IDONTWANT state right before sending RPC #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be careful to not drop piggybacked messages (or at least re-queue them) |
|
Before merging, we should add metrics to this so we can measure how effective this is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #611.
A bit hacky, and there's a couple of footguns with the various RPC copies.
It would be nice to use a context for this, but it doesn't work well because the send is async so we'd have to keep the context around long enough for the send to finish and then clean it up.
Having the rpc check a map behind a lock is one of the cheapest options.
A slight improvement here would be to send the cancelled function separately from the RPC at the expense of more code changes.
Another approach is to change the priority queue to be aware of cancellation, but I think this looks a lot like this approach.