Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #726
Passing a
trio.Nurseryintolisten()was messy. It forced theSwarmto micro-manage the lifecycle of every transport listener, which leaked implementation details and made the API awkward to use. Simply put, theSwarmwas doing work that the Listener should have been doing itself.How was it fixed?
This PR moves the nursery management inside the listeners.
Instead of asking for a nursery,
TCPListener,WebsocketListener, andQUICListenernow spin up their own internal nurseries using system tasks. This keeps the concurrency logic encapsulated where it belongs.Changes:
nurseryargument was dropped fromIListener.listen(maddr).close()properly cancels these internal tasks so we don't leave orphans hanging around.