use % 2 == 0 instead of is_multiple_of to check parity, #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariusc93
approved these changes
Sep 23, 2025
dariusc93
reviewed
Sep 23, 2025
|
|
||
| pub fn is_server(self) -> bool { | ||
| self.0.is_multiple_of(2) | ||
| self.0 % 2 == 0 |
There was a problem hiding this comment.
Looks like you might want to allow clippy::manual-is-multiple-of
to support older Rust versions
jxs
force-pushed
the
support-older-rust
branch
from
9bbdbbf to
d3e8ff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to support older Rust versions
fixes #207