Switch 2 Controller Support #13327

flibitijibibo · 2025-07-05T18:55:43Z

Device init and polling works, but I haven't translated the packets yet since ~~the public code doesn't line up with the automatic mappings~~ and I'm intentionally avoiding doing any further reverse engineering myself. Happy to add patches to get this PR working though!

udev rule for Linux:

SUBSYSTEM=="usb", ENV{DEVTYPE}=="usb_device", ATTRS{idVendor}=="057e", ATTRS{idProduct}=="2073", MODE="0666"

CC @Nohzockt: If you have a preferred name/email for Co-authored-by I'll apply it to the patch that implements the init/polling work.

Nohzockt · 2025-07-05T21:05:41Z

Fixes #13178.

Device init and polling works, but I haven't translated the packets yet since the public code doesn't line up with the automatic mappings and I'm intentionally avoiding doing any further reverse engineering myself. Happy to add patches to get this PR working though!

udev rule for Linux:
SUBSYSTEM=="usb", ENV{DEVTYPE}=="usb_device", ATTRS{idVendor}=="057e", ATTRS{idProduct}=="2073", MODE="0666"
CC @Nohzockt: If you have a preferred name/email for Co-authored-by I'll apply it to the patch that implements the init/polling work.

Well, my preferred name would be just Nohzockt or Noah, no email or something special. I feel honoured that you ask me. Thanks a lot.

flibitijibibo · 2025-07-05T21:33:31Z

Done!

I also cleaned up the button reading and made a working gamepad mapping, once the left/right stick are working this is ready to review.

nilsojc · 2025-07-06T11:26:22Z

Quick question. I was able to generate an SDL3.dll file with your WIP stub, would an SDL2.dll be able to be generated as well or this still a work in progress? I am wondering how these can be built for executables like emulators or steam API.

src/hidapi/libusb/hid.c

endrift · 2025-07-08T01:31:29Z

I have some devices I can test in addition to the GC controller so I might want to add those to this PR if possible. I can create a branch off of your branch, or add them after this is merged.

flibitijibibo · 2025-07-08T01:46:11Z

Whatever works! I can add commits to this PR if Sam doesn't get to it first.

src/hidapi/libusb/hid.c

src/joystick/SDL_joystick.c

src/joystick/hidapi/SDL_hidapi_switch2.c

slouken · 2025-07-11T19:06:17Z

src/joystick/hidapi/SDL_hidapi_switch2.c

+    int size;
+    while ((size = SDL_hid_read_timeout(device->dev, packet, sizeof(packet), 0)) > 0) {
+        if (size > 14) {
+            Uint64 timestamp = SDL_GetTicksNS();


This block should be refactored out into a separate function to handle devices with varying capabilities and report formats.

I believe all NS2 devices report the same layout (passing 0 for unsupported axes like the GCN triggers) but @endrift can confirm this.

slouken · 2025-07-12T00:11:31Z

Does this support Bluetooth? What changes would need to be made for rumble and gyro support?

endrift · 2025-07-12T00:14:06Z

I haven't looked over the code yet, but I tested the controller and discovered a few things that might want improvements:

The ranging of everything analog isn't saturating. Wholly unpressed triggers have non-zero values, and wholly pressed triggers as well as wholly tilted sticks don't reach anywhere close to the full values.
The share and C buttons register, but aren't mapped to any gamepad buttons. The Xbox One controller maps the share button to Misc1, so we might want to do the same thing for the share button here. Though we might want to have a named share button in SDL too.

endrift · 2025-08-08T01:40:06Z

Unfortunately no, the only interface that's exposed as-is is the first interrupt endpoint

juanmanjarres · 2025-08-20T21:20:04Z

Hi, I've been following the development of this for a bit since I got a GC NS2 controller, I saw on the open issue that there's some work to be done for the sticks and triggers, I wonder if there's any way I could help? I'm not super familiar with the code here, but I'd be happy to contribute. I currently have a mac if that helps

endrift · 2025-08-20T23:10:09Z

Unfortunately the current holdup is mostly about internal design issues. The calibration stuff can be fairly easily solved once that's resolved based on information provided both in this thread and on other sites in the meantime.

endrift · 2025-08-23T01:05:23Z

I've started looking into how to plumb through the necessary pointers and I'm not really making much progress. Short of really hacky smuggling of pointers and type punning, I'm not sure any even halfway-decent way to architect this. The SDL_hidapi abstraction layer doesn't provide a way of determining the backend so you can safely cast the device pointer, afaict, but maybe I'm overlooking how the ifdefs are used.

I would appreciate it if someone who's more familiar with the codebase could "bless" a way to get the libusb_device pointer out of a SDL_HIDAPI_Device.

The alternative, however, is adding "side channels" to SDL_HIDAPI_Devices that you can look up and communicate with. While most game controllers only have one channel to worry about, we will need to deal with side channels once we get to bluetooth too.

flibitijibibo · 2025-08-23T13:18:23Z

My plan was likely going to be to do all the bulk interactions on init and add the calibration data as a pointer property to the hid_device; this assumes that all the work could fit in init_ns2 though... I'm just skipping rumble for now, that's a whole other issue that might become obsoleted if we ever figure out BLE support.

slouken · 2025-08-25T17:34:53Z

I have a Nintendo Switch 2 Pro controller now, and a plan to plumb the secondary device through. I'll take a swing at this when I have time, hopefully sometime this week.

endrift · 2025-08-26T02:26:55Z

After that's plumbed through, adding calibration should be enough for an initial merge. Rumble will have to wait a bit, as will bluetooth, but those can come later I think

slouken · 2025-08-27T18:44:28Z

I checked out your branch and built with libusb support, but I'm not seeing any packets come in, after successful initialization. I'm running on Windows, hopefully that doesn't matter. Any ideas?

flibitijibibo · 2025-08-27T18:56:10Z

Only thing I can think of is it needing the WinUSB fuss like the GameCube adapter did, but I haven't seen anyone else use it - @endrift have you tried this on Windows by chance?

slouken · 2025-08-27T18:57:32Z

I checked out your branch and built with libusb support, but I'm not seeing any packets come in, after successful initialization. I'm running on Windows, hopefully that doesn't matter. Any ideas?

Ah, the problem was that the interface wasn't claimed. I'll add a commit to the PR to fix that.

…roller

slouken · 2025-08-27T22:53:59Z

Okay, the libusb bulk endpoint is now available to the driver. Party on!

madebr · 2025-08-27T23:03:03Z

src/misc/SDL_libusb.c

+#include "SDL_libusb.h"
+
+#ifdef HAVE_LIBUSB
+


Suggested change

#ifdef SDL_LIBUSB_DYNAMIC

SDL_ELF_NOTE_DLOPEN(

"libusb",

"Support for joysticks through libusb",

SDL_ELF_NOTE_DLOPEN_PRIORITY_SUGGESTED,

SDL_LIBUSB_DYNAMIC

);

#endif

That won't compile yet, this PR is based on older SDL3 main. We'll have to add that after it's merged.

That's also why I didn't regenerate the dynapi files, because I don't want to cause conflicts there.

…idapi_switch2.c

slouken · 2025-08-28T16:10:43Z

Okay, I think this is ready for iteration in main, so I'll go ahead and merge it. Thanks everyone who contributed!

OddOttAllen · 2025-08-28T16:46:07Z

hey, is it a case where we had to have connected the controllers to a Switch 2 system already for it to work on PC via SDL? or are we all good out of the box?

slouken · 2025-08-28T17:19:09Z

hey, is it a case where we had to have connected the controllers to a Switch 2 system already for it to work on PC via SDL? or are we all good out of the box?

They'll work out of the box. Note that SDL needs to be built with libusb support and have access to low level USB devices which isn't usually the case. We'll have to figure out messaging around that.

OddOttAllen · 2025-08-28T20:17:24Z

They'll work out of the box. Note that SDL needs to be built with libusb support and have access to low level USB devices which isn't usually the case. We'll have to figure out messaging around that.

does steam do that with the version of SDL in their client? sorry for being a total newbie/outsider/etc asking all this LOL

slouken · 2025-08-28T21:21:21Z

They'll work out of the box. Note that SDL needs to be built with libusb support and have access to low level USB devices which isn't usually the case. We'll have to figure out messaging around that.

does steam do that with the version of SDL in their client? sorry for being a total newbie/outsider/etc asking all this LOL

Steam does not build SDL with libusb enabled, since that normally requires root permissions and you should not run Steam as root. We'll figure out the right path forward once this driver matures and is ready for prime time.

endrift · 2025-08-28T23:53:49Z

I'm pretty frustrated you just went ahead and merged this without additional feedback. It wasn't ready and now I'm gonna have to fix it on main instead in a PR.

slouken · 2025-08-29T00:16:54Z

I'm pretty frustrated you just went ahead and merged this without additional feedback. It wasn't ready and now I'm gonna have to fix it on main instead in a PR.

Sorry, I didn't realize you were actively working on this, feel free to submit a PR when you're ready.

flibitijibibo mentioned this pull request Jul 5, 2025

Add support for NS2 GameCube controller #13178

Closed

flibitijibibo marked this pull request as draft July 5, 2025 18:58

flibitijibibo force-pushed the s2stub branch from 620f3ba to 20f3114 Compare July 5, 2025 19:10

flibitijibibo force-pushed the s2stub branch from 20f3114 to 864b463 Compare July 5, 2025 21:32

flibitijibibo force-pushed the s2stub branch from 864b463 to 27346e0 Compare July 5, 2025 23:37

flibitijibibo force-pushed the s2stub branch from 27346e0 to ac016b6 Compare July 6, 2025 15:59

flibitijibibo changed the title ~~[DONOTMERGE] Switch 2 GameCube Controller Support~~ Switch 2 GameCube Controller Support Jul 6, 2025

flibitijibibo marked this pull request as ready for review July 6, 2025 16:00

flibitijibibo requested a review from slouken July 6, 2025 16:00

flibitijibibo force-pushed the s2stub branch from ac016b6 to 008be2a Compare July 6, 2025 16:06

endrift reviewed Jul 6, 2025

View reviewed changes

src/hidapi/libusb/hid.c Outdated Show resolved Hide resolved

flibitijibibo force-pushed the s2stub branch from 008be2a to e7dc078 Compare July 6, 2025 23:57

flibitijibibo mentioned this pull request Jul 9, 2025

Implement SInput Device Support #13343

Merged