Introduce enum for SDL_GetCameraPermissionState result #13756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezero
requested review from
slouken and
icculus
and removed request for
slouken
|
This actually looks like a really good change to me. @icculus, thoughts? |
|
Yeah, I'm merging it. I think we're probably okay on ABI compatibility here. |
|
One issue, at least, would be that if someone makes a function pointer for SDL_GetCameraPermissionState, he'll encounter errors changing SDL versions. |
Compile time errors are fine here, it's just ABI compatibility that would be an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The values returned from
SDL_GetCameraPermissionStateare a small set (-1, 0, 1).Those integer values are defined and set directly within SDL code, and not pulled from system APIs, so I don't think there's a chance values could fall outside that enumerated range. So this introduces an enumeration for those values.
This does modify an existing API's return type, but I think it should mostly be compatible. The integer values are not changed.
I'm not sure if this type of change is welcome or not. It's not a bug fix and it technically affects the signature of an existing API, though I think it is changed in a compatible way.
Existing Issue(s)
n/a