docs: add French installation guide for LND on Debian/Ubuntu #10284
Conversation
Summary of ChangesHello @mcieric, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new French-language installation guide for LND on Debian/Ubuntu, aiming to enhance accessibility and ease of setup for French-speaking developers. The addition of this localized documentation helps broaden the reach of LND by providing clear, step-by-step instructions for a specific operating system environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a French translation of the LND installation guide for Debian/Ubuntu. This is a great initiative to make LND more accessible to French-speaking users. My review focuses on ensuring the instructions are accurate and will lead to a successful installation. I've identified a few areas for improvement: the Go version prerequisite is outdated, the recommended Go installation method could be unreliable for some users, and one of the build commands is redundant. I've provided suggestions to correct these points to improve the guide's clarity and reliability.
|
|
||
| ## 1. Prérequis | ||
| - Linux Debian/Ubuntu | ||
| - Go 1.20+ |
There was a problem hiding this comment.
The required Go version is 1.24.6 or newer, not 1.20+. This is specified in the main INSTALL.md file and the project's Makefile. Using an older version of Go will likely lead to compilation errors.
| - Go 1.20+ | |
| - Go 1.24.6+ |
| # Installer Go si nécessaire | ||
| sudo apt update && sudo apt install golang-go git -y |
There was a problem hiding this comment.
The golang-go package from the default Debian/Ubuntu repositories might be outdated and not meet the minimum version requirement of 1.24.6+. This can cause the build to fail. It would be better to add a note to warn the user about this and suggest they verify the installed version.
| # Installer Go si nécessaire | |
| sudo apt update && sudo apt install golang-go git -y | |
| # Installer Go (v1.24.6+ requis) et Git. La version d'apt peut être ancienne, vérifiez avec `go version`. | |
| sudo apt update && sudo apt install golang-go git -y |
| cd lnd | ||
|
|
||
| # Compiler | ||
| make && make install |
There was a problem hiding this comment.
The make install command is sufficient to build and install the binaries. Running make before it is redundant, as make install already handles the compilation. The main INSTALL.md guide also uses just make install for simplicity and correctness.
| make && make install | |
| make install |
|
i don't think these multi-language docs right now makes sense since everybody just can ask LLMs |
It seems this proposed approach favor people who have access to LLMs and can potentially afford paid subscriptions if the free version proves insufficient. Typically, documentation localization in OSS repositories follows patterns like this approach (https://github.com/orgs/community/discussions/22310#discussioncomment-3236243) when the documentation target audience spans different spoken languages. However, it could be argued that LND documentation targets an audience capable of reading and interpreting English, with users employing their own preferred methods for conversion or translation as needed. |
|
Closed based on the above comments. |
4 participants
Summary
Added a French installation guide for LND on Debian/Ubuntu.
Changes
Created docs/fr/installation-debian.md
Covered prerequisites (Go, Git, Bitcoin node)
Installation steps on Debian/Ubuntu
Basic run command and version check
Notes
Documentation only, no code changes
Goal: help French-speaking developers install and use LND more easily