Skip to content

Prevent double-execution of script tags. #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

Prevent double-execution of script tags. #908

merged 2 commits into from
Jul 23, 2025

Conversation

karlseguin
Copy link
Collaborator

sjorsdonkers
sjorsdonkers approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@sjorsdonkers sjorsdonkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 layers of indirection to access a boolean.
I feel we should make a plan to improve the current state otherwise it's going to be to hard to change everything later on.

@karlseguin karlseguin merged commit f7f3822 into main Jul 23, 2025
10 checks passed
@karlseguin karlseguin deleted the guard_against_double_script_execution branch July 23, 2025 13:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sjorsdonkers sjorsdonkers sjorsdonkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlseguin @sjorsdonkers