Make sure the port forwarding protocol is always lowercase #2825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ServicePort.Protocol is always uppercase, e.g. "TCP", but the api.IPPort.protocol is always lowercase, i.e. "tcp". Since UDP support was added in lima-vm#2411 the hostagent filters on the protocol values. Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
k8s-portforwarding
branch
from
4856e73 to
9aaa7bb
Compare
|
Testing (fails without this PR, succeeds after it is applied): limactl start --tty=false template://k3s
export KUBECONFIG="$HOME/.lima/k3s/copied-from-guest/kubeconfig.yaml"
kubectl create deployment nginx --image=nginx
kubectl create service nodeport nginx --tcp=80:80 --node-port=32000
curl http://localhost:32000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ServicePort.Protocol is always uppercase, e.g. "TCP", but the api.IPPort.protocol is always lowercase, i.e. "tcp".
Since UDP support was added in #2411 the hostagent filters on the protocol values.
cc @pendo324 @balajiv113 @Nino-K