Skip to content

templates: update #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

templates: update #2848

merged 1 commit into from
Nov 5, 2024

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Nov 5, 2024

No description provided.

@AkihiroSuda
templates: update
9769138 
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda added this to the v1.0 milestone Nov 5, 2024
jandubois
jandubois approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

I've only tested the almalinux-8 template on Intel. I assume we just trust the update scripts to generate working URLs and checksums. Or do we download and verify that they are all functional?

@jandubois jandubois merged commit 3e01f25 into lima-vm:master Nov 5, 2024
29 checks passed
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Nov 5, 2024

Yes, we are just relying on the script

@crazy-max crazy-max mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jandubois jandubois jandubois approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AkihiroSuda @jandubois