Use consistent naming for VMOpts and vmOpts #3997
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Sep 8, 2025
| @@ -20,7 +20,7 @@ type LimaYAML struct { | |||
| OS *OS `yaml:"os,omitempty" json:"os,omitempty" jsonschema:"nullable"` | |||
| Arch *Arch `yaml:"arch,omitempty" json:"arch,omitempty" jsonschema:"nullable"` | |||
| Images []Image `yaml:"images,omitempty" json:"images,omitempty" jsonschema:"nullable"` | |||
| // Deprecated: Use VMOpts.Qemu.CPUType instead. | |||
| // Deprecated: Use VMOpts.QEMU.CPUType instead. | |||
There was a problem hiding this comment.
Soon:
Suggested change
| // Deprecated: Use VMOpts.QEMU.CPUType instead. | |
| // Deprecated: Use VMOpts["qemu"].CPUType instead. |
There was a problem hiding this comment.
I used the yaml names since they are less ugly, but that is the "after" state and this was the "before" state...
There was a problem hiding this comment.
pkg/limatype/lima_yaml.go: VMOpts VMOpts `yaml:"vmOpts,omitempty" json:"vmOpts,omitempty"`
pkg/limatype/lima_yaml.go: // Deprecated: Use vmOpts.qemu.cpuType instead.
pkg/limatype/lima_yaml.go: // Deprecated: Use vmOpts.vz.rosetta instead.
pkg/limatype/lima_yaml.go:type VMOpts map[VMType]any
go: VMOpts.QEMU.CPUType, VMOpts.VZ.Rosetta yaml: vmOpts.qemu.cpuType, vmOpts.vz.rosetta Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
vmopts-typo
branch
from
17647b2 to
cdc5098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go: VMOpts.QEMU.CPUType, VMOpts.VZ.Rosetta
yaml: vmOpts.qemu.cpuType, vmOpts.vz.rosetta
Found while moving VMOpts to a separate type.
It is only in the comments actually, but anyway.