Skip to content

Fix: make uninstall should remove external drivers #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

Fix: make uninstall should remove external drivers #4034

merged 1 commit into from
Sep 16, 2025

Conversation

unsuman
Copy link
Contributor

@unsuman unsuman commented Sep 15, 2025

@unsuman unsuman mentioned this pull request Sep 15, 2025
Merged
2 tasks
@afbjorklund
Copy link
Member

Wouldn't you normally just uninstall what you install? Those external drivers probably have a matching set

jandubois
jandubois reviewed Sep 15, 2025
View reviewed changes
@jandubois
Copy link
Member

Wouldn't you normally just uninstall what you install? Those external drivers probably have a matching set

What you install depends on additional environment settings, which may have changed when you run uninstall. So I think you should install all things you possibly could have installed, but nothing else.

@jandubois
Copy link
Member

Note that in the case of /usr/local/share/lima and /usr/local/share/doc/lima we completely wipe the directories, which seems wrong too. At least for the docs it is conceivable that you want to install e.g. external plugin docs there too.

It is not clear to me if we support storing custom templates in /usr/local/share/lima/templates or not. There are alternatives though, like $LIMA_HOME/_templates or any directory on LIMA_TEMPLATES_PATH.

jandubois
jandubois reviewed Sep 15, 2025
View reviewed changes
jandubois
jandubois reviewed Sep 15, 2025
View reviewed changes
jandubois
jandubois reviewed Sep 16, 2025
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois added this to the v2.0.0 milestone Sep 16, 2025
@jandubois jandubois merged commit da1f0cc into lima-vm:master Sep 16, 2025
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@unsuman @afbjorklund @jandubois