security/keys/Kconfig: add KEYS_COMPAT option for keyctl tool #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
How does this relate to upstream? Is it possible to cherry-pick a few commits to achieve the same purpose? |
kkamagui
force-pushed
the
rpi3-optee-4.6
branch
from
a8dcbb9 to
177734f
Compare
|
It seems that the commit torvalds@47b2c3f is related to my pull-request in Linux kernel source tree. |
|
Can we use torvalds/linux@47b2c3f instead then? |
|
Oh, that's good point. I will check that and update the progress about it. |
CONFIG_KEYS_COMPAT is defined in arch-specific Kconfigs and is missing for several 64-bit architectures : mips, parisc, tile. At the moment and for those architectures, calling in 32-bit userspace the keyctl syscall would return an ENOSYS error. This patch moves the CONFIG_KEYS_COMPAT option to security/keys/Kconfig, to make sure the compatibility wrapper is registered by default for any 64-bit architecture as long as it is configured with CONFIG_COMPAT. [DH: Modified to remove arm64 compat enablement also as requested by Eric Biggers] Signed-off-by: Bilal Amarni <[email protected]> Signed-off-by: David Howells <[email protected]> Reviewed-by: Arnd Bergmann <[email protected]> cc: Eric Biggers <[email protected]> Signed-off-by: James Morris <[email protected]> Link: https://patchwork.kernel.org/patch/9565609/ (cherry picked from commit 47b2c3f) Tested-by: Seunghun Han <[email protected]>
kkamagui
force-pushed
the
rpi3-optee-4.6
branch
from
177734f to
4370eff
Compare
|
I cherry-picked the torvalds@47b2c3f commit from Linux kernel repository instead of my commit and tested it. |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Keyctl tool of Raspbian OS doesn't work because Linux kernel of the rpi3
branch doesn't have compat_key functions.
To solve this problem, KEYS_COMPAT option is added to security/keys/Kconfig
file.
Signed-off-by: Seunghun Han [email protected]