sha: new example for SHA HMAC and Digest algos #136
Conversation
|
This PR has code style issues, and I think it's more complicated than necessary. However, if no one else cares, I'm going to ack this by the end of the week. |
|
|
|
Sorry @jenswi-linaro, maybe I'm a bit too nitpicking on examples. Feel free to tell if some of my comments are overkilling. |
|
I don't mind. The code in this git isn't as consistent as in the repositories under http://github.com/OP-TEE. |
|
Maybe worth to have a cleanup on these. They are expected to be examples. Not critical though :-) |
Hi @etienne-lms since the TA specifically focuses on SHA HMAC and SHA digest functionalities, I thought naming the TA 'SHA' would be more accurate as it reflects its purpose and scope. |
Fair enough. |
Add new example for MAC and digest algorithms The user can now invoke: optee_example_sha <string> <algo> <algo>: algorithm name. Supported values for algo are: - TA_ALGO_HMAC_SHA256 (default) - TA_ALGO_HMAC_SHA1 - TA_ALGO_HMAC_SHA224 - TA_ALGO_HMAC_SHA384 - TA_ALGO_HMAC_SHA512 - TA_ALG_SHA1 - TA_ALG_SHA224 - TA_ALG_SHA256 - TA_ALG_SHA384 - TA_ALG_SHA512 - TA_ALG_SHA3_224 - TA_ALG_SHA3_256 - TA_ALG_SHA3_384 - TA_ALG_SHA3_512 - TA_ALG_SHAKE128 - TA_ALG_SHAKE256 Signed-off-by: Amey Avinash Raghatate <[email protected]> State: waiting Link: linaro-swg#136
|
@etienne-lms can we close on this? |
There was a problem hiding this comment.
Some last comments.
My Reviewed-by: Etienne Carriere <[email protected]> tag once addressed.
Thanks for this example (and all the others you also submitted).
Add new example for MAC and digest algorithms The user can now invoke: optee_example_sha <string> <algo> <algo>: algorithm name. Supported values for algo are: - HMAC_SHA1 - HMAC_SHA224 - HMAC_SHA256 (default) - HMAC_SHA384 - HMAC_SHA512 - AES_CMAC - SHA1 - SHA224 - SHA256 - SHA384 - SHA512 - SHA3_224 - SHA3_256 - SHA3_384 - SHA3_512 - SHAKE128 - SHAKE256 Signed-off-by: Amey Avinash Raghatate <[email protected]> Reviewed-by: Jerome Forissier <[email protected]> Reviewed-by: Etienne Carriere <[email protected]> Acked-by: Jens Wiklander <[email protected]>
Akshay-Belsare
force-pushed
the
amd_sha_example
branch
from
0f3970a to
7aece04
Compare
|
@etienne-lms all review comments are addressed. |
5 participants
Add new example for MAC and digest algorithms
The user can now invoke:
optee_example_sha
: algorithm name. Supported values for algo are: