Skip to content

Use SubscriptionBuilder.properties() to set property supplier #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2025
Merged

Use SubscriptionBuilder.properties() to set property supplier #206

merged 2 commits into from
Nov 4, 2025

Conversation

@pppurple
Copy link
Contributor

@pppurple pppurple commented May 22, 2023

When user instantiates ProcessorSubscription using SubscriptionBuilder, it seems appropriate to use SubscriptionBuilder.properties() to set property supplier, rather than using props.setBySupplier() directly.

@CLAassistant
Copy link

CLAassistant commented May 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pppurple pppurple marked this pull request as ready for review October 30, 2025 01:44
Yang-33
Yang-33 approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Yang-33 Yang-33 merged commit bf6e507 into line:master Nov 4, 2025
6 checks passed
@pppurple pppurple deleted the fix-dynamic-property-configuration branch November 4, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yang-33 Yang-33 Yang-33 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pppurple @CLAassistant @Yang-33