Skip to content

fix edge case #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix edge case #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zmq/asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def _clear_io_state(self):
called once at close
"""
loop = self._current_loop
if loop and not loop.is_closed() and self._fd != -1:
if loop and not loop.is_closed():
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐞 Bug - Invalid File Descriptor: Restore the self._fd != -1 check in the condition to ensure only valid file descriptors are passed to remove_reader(), or add explicit validation before calling remove_reader().

Suggested change
if loop and not loop.is_closed():
if loop and not loop.is_closed() and self._fd != -1:

self._get_selector(loop).remove_reader(self._fd)


Expand Down