-
Notifications
You must be signed in to change notification settings - Fork 175
Testing: profiles for padding, padding color, post-creation config #1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tion Adds support for configuring how padding in renders done by Masonry Testing is done at runtime. Also adds support for configuring the padding colour Additionally, this adds targeted methods for the archetypes of screenshots identified in linebender#1457
d6ab9cf to
4b9240f
Compare
ae3131a to
5f6783d
Compare
PoignardAzur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember if we talked about this, so I'll just leave a review now: I'm not a fan of the new padding color in the changed screenshots. In fact, I'd maybe consider it a regression.
I think having the padding color be a different color than the background (e.g. what you see behind the rounded corners) is visually confusing and kind of defeats the point of adding padding in the first place.
I'm open to changing my mind if there's a strong rationale though.
|
I'm happy to remove the colour. I still think that having padding in the vast majority of screenshot tests is valuable:
I do feel that having some indication of what the padding region is does have value, in that it allows "unintentional" overdraw to be caught. Overdraw can at least be manually detected with the debug paint? As a procedural note, we seem to be talking past each other. Once we remove the default padding colour from this PR (or in the follow-up to actually enable the default padding), we're back in the state from before #1457 (review), in that the newly added default padding wouldn't be discoverable. However, there is another assumption which this PR is making, which might not be true, which is that the "screenshot of individual widgets" case is the common-case. It certainly is in this repo, but it really isn't for users of Masonry. Because of this, it feels like there might be some solution which satisfies all of our needs. I'm not sure however how to make such an explicit API ergonomic, whilst still being explicit enough that padding is being added to meet your discover-ability targets (e.g. saying |
Adds support for configuring how padding in renders done by Masonry Testing is done at runtime.
Also adds support for configuring the padding colour.
Additionally, this adds targeted methods for the archetypes of screenshots identified in #1457
This is now applied to
button(andtext_input, as if it were the default)