-
Notifications
You must be signed in to change notification settings - Fork 153
Integration tests #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests #814
Conversation
ezilber-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! I am getting one error for the clusters test suite though:
AssertionError: Unexpected tier value: . Expected one of ('standard', 'enterprise', 'false').
E assert '' in ('standard', 'enterprise', 'false')
I think it has something to do with the headers list. It's probably pulling from the wrong one.
|
I wonder if there is something wrong with the spec pushed to github. I tried to rebuild the CLI with the spec in the PR: But got the following error: |
|
@yec-akamai The spec linked in the PR is outdated now. I'll send you a link with the current one. |
ezilber-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
yec-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passed locally!
📝 Description
Integration test covering Metric , Alerts , LKE-Phase2 changes and Maintenance Polices
These are tested against the new openapi changes - linode-api-docs
Updated akamai-api-inventory
✔️ How to Test
make test-int TEST_CASE=test_metrics
make test-int TEST_CASE=test_alerts
make test-int TEST_CASE=test_account
make test-int TEST_CASE=test_clusters.py
make test-int TEST_CASE=test_maintenance_policies
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.