Skip to content

Conversation

@vshanthe
Copy link
Contributor

@vshanthe vshanthe commented Sep 8, 2025

📝 Description

Integration test covering Metric , Alerts , LKE-Phase2 changes and Maintenance Polices
These are tested against the new openapi changes - linode-api-docs

Updated akamai-api-inventory

✔️ How to Test

make test-int TEST_CASE=test_metrics
make test-int TEST_CASE=test_alerts
make test-int TEST_CASE=test_account
make test-int TEST_CASE=test_clusters.py
make test-int TEST_CASE=test_maintenance_policies

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@vshanthe vshanthe requested a review from a team as a code owner September 8, 2025 13:03
@vshanthe vshanthe requested review from ezilber-akamai, lgarber-akamai and zliang-akamai and removed request for a team September 8, 2025 13:03
@yec-akamai yec-akamai self-requested a review September 9, 2025 14:08
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! I am getting one error for the clusters test suite though:

AssertionError: Unexpected tier value: . Expected one of ('standard', 'enterprise', 'false').
E           assert '' in ('standard', 'enterprise', 'false')

I think it has something to do with the headers list. It's probably pulling from the wrong one.

yec-akamai

This comment was marked as outdated.

@yec-akamai
Copy link
Contributor

I wonder if there is something wrong with the spec pushed to github. I tried to rebuild the CLI with the spec in the PR:

 make intall SPEC=https://raw.githubusercontent.com/wildmanonline/linode-api-docs/6f0fd11c1a6c25797e0c99bfee43ac2d23659352/openapi.json

But got the following error:

Failed to load spec: Expected paths./{apiVersion}/images/sharegroups/{sharegroupId}/images.post.requestBody.content.application/json.schema.properties.images.items.properties.id to be of type Schema or Reference, but did not find required fields [] or '$ref'
make: *** [bake] Error 2

@ezilber-akamai
Copy link
Contributor

ezilber-akamai commented Sep 9, 2025

@yec-akamai The spec linked in the PR is outdated now. I'll send you a link with the current one.

Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed locally!

@vshanthe vshanthe merged commit be6e62f into dev Sep 10, 2025
22 checks passed
@zliang-akamai zliang-akamai added the testing for updates to the testing suite in the changelog. label Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants