-
Notifications
You must be signed in to change notification settings - Fork 153
Adds integration tests for private image sharing #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds integration tests for private image sharing #833
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive integration tests for the private image sharing feature through share groups. The tests validate CRUD operations, token management, member operations, and error handling for invalid inputs.
Key changes:
- New test suite covering all image-sharegroups CLI actions and error scenarios
- Pytest fixtures for creating test resources (share groups, images, regions)
- Updated regex pattern in helpers to support comma-separated action names in help output
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/integration/sharegroups/test_images_sharegroups.py | Adds 16 test functions covering share group operations, image management, token handling, and member management |
| tests/integration/sharegroups/fixtures.py | Adds fixtures for creating test share groups, images, and retrieving regions with image status polling |
| tests/integration/helpers.py | Updates regex pattern to parse help output with comma-separated actions and adds image-sharegroups to BASE_CMDS |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0dcee60 to
9c949d8
Compare
ezilber-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test suite looks thorough and passes locally. Great work!
|
May be you need to run make lint and make format to fix the CI failure |
9c949d8 to
f1bc1ed
Compare
f1bc1ed to
56f1ad1
Compare
56f1ad1 to
5fb159d
Compare
You are right. It is done and now all checks have passed. Thank you! |
vshanthe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working locally , Nice work!
📝 Description copied from Copilot
This PR adds comprehensive integration tests for the private image sharing feature through share groups. The tests validate CRUD operations, token management, member operations, and error handling for invalid inputs.
Key changes:
New test suite covering all image-sharegroups CLI actions and error scenarios
Pytest fixtures for creating test resources (share groups, images, regions)
Updated regex pattern in helpers to support comma-separated action names in help output.
✔️ How to Test
make test-int TEST_CASE=sharegroups