Skip to content

Conversation

@PawelSnoch
Copy link
Contributor

@PawelSnoch PawelSnoch commented Nov 18, 2025

📝 Description copied from Copilot

This PR adds comprehensive integration tests for the private image sharing feature through share groups. The tests validate CRUD operations, token management, member operations, and error handling for invalid inputs.

Key changes:

New test suite covering all image-sharegroups CLI actions and error scenarios
Pytest fixtures for creating test resources (share groups, images, regions)
Updated regex pattern in helpers to support comma-separated action names in help output.

✔️ How to Test

make test-int TEST_CASE=sharegroups

@PawelSnoch PawelSnoch requested a review from a team as a code owner November 18, 2025 18:17
@PawelSnoch PawelSnoch requested review from vshanthe and zliang-akamai and removed request for a team November 18, 2025 18:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive integration tests for the private image sharing feature through share groups. The tests validate CRUD operations, token management, member operations, and error handling for invalid inputs.

Key changes:

  • New test suite covering all image-sharegroups CLI actions and error scenarios
  • Pytest fixtures for creating test resources (share groups, images, regions)
  • Updated regex pattern in helpers to support comma-separated action names in help output

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/integration/sharegroups/test_images_sharegroups.py Adds 16 test functions covering share group operations, image management, token handling, and member management
tests/integration/sharegroups/fixtures.py Adds fixtures for creating test share groups, images, and retrieving regions with image status polling
tests/integration/helpers.py Updates regex pattern to parse help output with comma-separated actions and adds image-sharegroups to BASE_CMDS

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@PawelSnoch PawelSnoch force-pushed the adds-integration-tests-for-private-image-sharing branch from 0dcee60 to 9c949d8 Compare November 18, 2025 18:33
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test suite looks thorough and passes locally. Great work!

@vshanthe
Copy link
Contributor

May be you need to run make lint and make format to fix the CI failure

@PawelSnoch PawelSnoch force-pushed the adds-integration-tests-for-private-image-sharing branch from 9c949d8 to f1bc1ed Compare November 19, 2025 12:21
@PawelSnoch PawelSnoch force-pushed the adds-integration-tests-for-private-image-sharing branch from f1bc1ed to 56f1ad1 Compare November 19, 2025 12:36
@PawelSnoch PawelSnoch force-pushed the adds-integration-tests-for-private-image-sharing branch from 56f1ad1 to 5fb159d Compare November 19, 2025 12:39
@PawelSnoch
Copy link
Contributor Author

May be you need to run make lint and make format to fix the CI failure

You are right. It is done and now all checks have passed. Thank you!

Copy link
Contributor

@vshanthe vshanthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working locally , Nice work!

@vshanthe vshanthe merged commit 1517717 into linode:dev Nov 19, 2025
14 checks passed
@ezilber-akamai ezilber-akamai added the testing for updates to the testing suite in the changelog. label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing for updates to the testing suite in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants