Skip to content

Fix test for interfaces #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

Fix test for interfaces #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/integration/models/linode/interfaces/test_interfaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,15 @@ def __assert_vlan(iface: LinodeInterface):
assert iface.vlan.vlan_label == "test-vlan"
assert iface.vlan.ipam_address == "10.0.0.5/32"

__assert_public(instance.interfaces[0])
__assert_vpc(instance.interfaces[1])
__assert_vlan(instance.interfaces[2])
__assert_public(instance.linode_interfaces[0])
__assert_vpc(instance.linode_interfaces[1])
__assert_vlan(instance.linode_interfaces[2])

instance.invalidate()

__assert_public(instance.interfaces[0])
__assert_vpc(instance.interfaces[1])
__assert_vlan(instance.interfaces[2])
__assert_public(instance.linode_interfaces[0])
__assert_vpc(instance.linode_interfaces[1])
__assert_vlan(instance.linode_interfaces[2])


@pytest.fixture
Expand Down
31 changes: 20 additions & 11 deletions test/integration/models/linode/test_linode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,37 +706,46 @@ def __assert_vlan(iface: LinodeInterface):
__assert_vlan(result.interfaces[1])
__assert_vpc(result.interfaces[2])

__assert_public(linode.interfaces[0])
__assert_vlan(linode.interfaces[1])
__assert_vpc(linode.interfaces[2])
__assert_public(linode.linode_interfaces[0])
__assert_vlan(linode.linode_interfaces[1])
__assert_vpc(linode.linode_interfaces[2])


def test_linode_interfaces_settings(linode_with_linode_interfaces):
linode = linode_with_linode_interfaces
settings = linode.interfaces_settings
settings = linode.linode_interfaces_settings

assert settings.network_helper is not None
assert settings.default_route.ipv4_interface_id == linode.interfaces[0].id
assert (
settings.default_route.ipv4_interface_id
== linode.linode_interfaces[0].id
)
assert settings.default_route.ipv4_eligible_interface_ids == [
linode.interfaces[0].id,
linode.interfaces[1].id,
linode.linode_interfaces[0].id,
linode.linode_interfaces[1].id,
]

assert settings.default_route.ipv6_interface_id == linode.interfaces[0].id
assert (
settings.default_route.ipv6_interface_id
== linode.linode_interfaces[0].id
)
assert settings.default_route.ipv6_eligible_interface_ids == [
linode.interfaces[0].id
linode.linode_interfaces[0].id
]

# Arbitrary updates
settings.network_helper = True
settings.default_route.ipv4_interface_id = linode.interfaces[1].id
settings.default_route.ipv4_interface_id = linode.linode_interfaces[1].id

settings.save()
settings.invalidate()

# Assert updates
assert settings.network_helper is not None
assert settings.default_route.ipv4_interface_id == linode.interfaces[1].id
assert (
settings.default_route.ipv4_interface_id
== linode.linode_interfaces[1].id
)


def test_config_update_interfaces(create_linode):
Expand Down