-
Notifications
You must be signed in to change notification settings - Fork 78
Add support for VPCSubnet.databases field #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for VPCSubnet.databases field #607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well on my end!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the databases field in VPC subnets to handle Managed Databases attached to VPC subnets. The implementation includes a new VPCSubnetDatabase class and corresponding property mapping.
- Adds
VPCSubnetDatabasedata class to represent database information within VPC subnets - Updates
VPCSubnetclass to include thedatabasesproperty - Adds comprehensive test coverage including fixtures and validation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| linode_api4/objects/vpc.py | Adds VPCSubnetDatabase class and databases property to VPCSubnet |
| test/unit/objects/vpc_test.py | Adds test validation for databases field functionality |
| test/fixtures/vpcs_123456_subnets_789.json | Adds test fixture data for single subnet with database |
| test/fixtures/vpcs_123456_subnets.json | Adds test fixture data for subnet list with database |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
* Added support for VPC DBaaS Integration (#560) * Implemented support for VPC DBaaS Integration * Added unit tests * Add support for VPCSubnet.databases field (#607) * Add support for VPCSubnet.databases field * ipv6_range -> ipv6_ranges * ipv6_range -> ipv6_ranges (list) --------- Co-authored-by: Erik Zilber <[email protected]>
📝 Description
This pull request adds support for the
databasesfield returned for VPC subnets with attached Managed Databases.✔️ How to Test
The following test steps assume you have pulled down this PR locally and run
make install.Unit Testing
Manual Testing