common/rc: add _have_crypto_algorithm #215
Open
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A crypto algorithm might be provided as built-in, thus check first if it is always present before trying to load as module. Signed-off-by: Daniel Wagner <[email protected]>
Collaborator
|
@igaw Thanks for this new PR, and sorry for my late response. The change looks good to me. I just wanted to replace the short option "-q" of the grep command with the long option "--quiet" for readability and reliability, and wanted to improve the commit message title to clarify the modification target test cases. I made these changes, and applied to the master branch as the commit fda2141. Please confirm the change is good for you. |
Collaborator
|
Sorry, I closed this PR by mistake. I intended to keep it open until @igaw confirm the change I made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A crypto algorithm might be provided as built-in, thus check first if it is always present before trying to load as module.
The idea to check the CONFIG flags is not enough. The algorithm needs to be present in the kernel.
/proc/cryptohas all the info./sys/modules/*will not show built-in modules.Fixes: ##197
Replaces: ##198