check nvme connect return codes
#216
Closed
+25
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to for the final / in the path. All users do add another / when concatenation a path. This makes the path look more consistent when debugging. Signed-off-by: Daniel Wagner <[email protected]>
Don't ignore the nvme connect return codes. This ensures that all transport behave the same. Signed-off-by: Daniel Wagner <[email protected]>
Collaborator
|
@igaw Thanks for this PR. This is great. I checked the two commits, and found two points below: With these changes, I applied the patches. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase test coverage by checking if
nvme connectis also reporting the expected return code.At least nvme/031 seems to trigger sometimes FAILs.
To my surprise, nvme/041 for FC is passing with https://lore.kernel.org/linux-nvme/[email protected]/ applied. Nice :)