zram: introduce compressed data writeback #411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: c2f2b01 |
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
ec9caac to
4a5ddea
Compare
zram stores all written back slots raw, which implies that during writeback zram first has to decompress slots (except for ZRAM_HUGE slots, which are raw already). The problem with this approach is that not every written back page gets read back (either via read() or via page-fault), which means that zram basically wastes CPU cycles and battery decompressing such slots. This changes with introduction of decompression on demand, in other words decompression on read()/page-fault. One caveat of decompression on demand is that async read is completed in IRQ context, while zram decompression is sleepable. To workaround this, read-back decompression is offloaded to a preemptible context - system high-prio work-queue. At this point compressed writeback is still disabled, a follow up patch will introduce a new device attribute which will make it possible to toggle compressed writeback per-device. [senozhatsky: rewrote original implementation] Signed-off-by: Richard Chang <[email protected]> Co-developed-by: Sergey Senozhatsky <[email protected]> Suggested-by: Minchan Kim <[email protected]> Suggested-by: Brian Geffon <[email protected]>
Introduce witeback_compressed device attribute to toggle compressed writeback (decompression on demand) feature. [senozhatsky: rewrote original patch, added documentation] Signed-off-by: Richard Chang <[email protected]> Co-developed-by: Sergey Senozhatsky <[email protected]>
Add missing writeback_batch_size documentation. Signed-off-by: Sergey Senozhatsky <[email protected]>
Move bd_stat function and attribute declaration to existing CONFIG_WRITEBACK ifdef-sections. Signed-off-by: Sergey Senozhatsky <[email protected]>
We don't free page in zram_free_page(), not all slots even have any memory associated with them (e.g. ZRAM_SAME). We free the slot (or reset it), rename the function accordingly. Signed-off-by: Sergey Senozhatsky <[email protected]>
Use init_lock guard() in sysfs store/show handlers, in order to simplify and, more importantly, to modernize the code. While at it, fix up more coding styles. Signed-off-by: Sergey Senozhatsky <[email protected]>
Do not spread device attributes declarations across the file, move io_stat, mm_stat, debug_stat to a common device-attr section. Signed-off-by: Sergey Senozhatsky <[email protected]>
Author
|
Upstream branch: d26143b |
blktests-ci
bot
force-pushed
the
series/1028747=>linus-master
branch
from
f780a21 to
5646e3c
Compare
Author
|
Upstream branch: d26143b |
1 similar comment
Author
|
Upstream branch: d26143b |
Author
|
Github failed to update this PR after force push. Close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: zram: introduce compressed data writeback
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1029165