Read PDU to send from binary file. #419
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartkopp
reviewed
Mar 26, 2023
| return 0; | ||
| } | ||
|
|
||
| if( (fd = open(filename, O_RDONLY)) == -1 ) { |
There was a problem hiding this comment.
no assignments in if-statements
please adopt the coding style with parenthesis and spaces
|
|
||
| ssize_t read_binary_file(void *buffer, const size_t siz_buffer, const char *filename) | ||
| { | ||
| int fd = -1; |
| ssize_t read_binary_file(void *buffer, const size_t siz_buffer, const char *filename) | ||
| { | ||
| int fd = -1; | ||
| ssize_t num_read = -1; |
| exit(1); | ||
| } | ||
|
|
||
| if( buflen < 1 ) { |
There was a problem hiding this comment.
if (buflen > 0) { ... ??
additional the indention seems wrong
| break; | ||
|
|
||
| case 'i': | ||
| buflen = read_binary_file(&buf[0], sizeof(buf), optarg); |
There was a problem hiding this comment.
use 'buf' instead of '&buf[0]'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Oliver,
as discussed, the implementation of reading PDU data from binary file instead of STDIN.
-- Carsten