-
Notifications
You must be signed in to change notification settings - Fork 111
Crash and delay fixes #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Please restructure your changes such that each commit does one thing only and give this a good commit message describing the problem that it is solving. Also add signed-off-by (git commit -s) to your commits. |
Signed-off-by: Yvonne Kaire <[email protected]>
Signed-off-by: Yvonne Kaire <[email protected]>
Signed-off-by: Yvonne Kaire <[email protected]>
…/qdl into crash-and-delay-fixes
|
@andersson, i think i restructured the commits. please let me know if there's any other changes i should make |
|
Please use "git rebase -i" rather than "git merge" to clean up the commits; in particular you have one commit that comments out parts of the Makefile and then another commit that reverts that patch. Once we merge this into the project, the git history wouldn't make sense. For the "prevent crash when filename is NULL", I would prefer if you write a short commit message describing why filename could be NULL. (see how I do for my changes in the git log) For the reset timeout, I think this would better be a separate PR, that we can merge independently. I would like the commit message to cover why it's needed (if you know, otherwise it should say that you don't know, but testing shows we need a value). And I would like the commit message to cover why 10 is a good value. Isn't 10 a long time? Why can't it be 1? I think the two changes as such looks good, I just want to understand why we're making them and for future readers of the code and git log to have this recorded. |
|
I checked this PR, seems like it's already handled by 1b9974c |
|
Yvonne cleaned up the patch-crash part and created PR #156, it's now clearer to me that we do have an issue here. |
Fixing crashes due to empty filenames
Adding reset delay