Updating gtk-2 assets and color variables #512
+58
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to point out that the old gtk-2 color theme used to have a color inconsistency in specific entries that are common in font selections. I thought that this wasn't made on purpose so I didn't replicate it on the new theme in this PR. 
current gtk-2 theme gtk-2 from this PR |
I made some more changes that fixed the mentioned inconsistency I also fixed the scrollbar and the checkbox inconsistencies. |
|
New assets and variations are updated in master_build branch for those who want a quick test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As metioned in the #511 issue, the themes of gtk-2 and gtk-3 apps are not consistent. The changes made to make them consistent only affects the hex color codes and the rest of the code remains unchanged. I tried to test them as much as I can. And even forced the gtk-2 themes to Qt apps to see how well the new theme behaves over there. So far I couldn't see any issues.
The pull request doesn't has the updated asset png's nor does it has the updated variations. I didn't staged those parts to avoid making a massive and unauditable PR.
Here are some screenshots of gtk-2 only apps with the new and old themes: