-
-
Notifications
You must be signed in to change notification settings - Fork 268
Rebase to 3.22 #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase to 3.22 #573
Conversation
I am a bot, here is the pushed image/manifest for this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
visual review only, did not test PR
I gave it a try and it worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried the new image and updated my confs. I am running behind CF proxy, and had no issues with the changes. Not sure if the CF proxy is masking any problems though, but nothing seems to indicate any issues.
looks like we should add a header https://nginx.org/en/docs/quic.html potentially put the quic reuseport above the 443 ssl too, esp in light of test from @goupilapps we will want a note in the readme too, quic uses both tcp and udp |
reuseport should be global for the same port/proto combinations. |
If we add that header and users aren't exposing 443/UDP it'll probably break things |
Does |
yes// sorry for short reply, the much larger discussion was in discord if you wanna look later; tl;dr things break in many cases, so it's all going in commented out. |
further testing and discussion was all internal, but consensus is to leave all quic stuff commented out because it CAN break things. some changes to this PR are forthcoming some notes, if you enable the header for quic and do not have udp/443 open, all of swag appears to break below is a script i used to update all my confs, create backups, i make no claims this script will work for you and i wont provide support or empathy if you choose to use it. it worked for me.
|
changes are required post-testing
I am a bot, here is the pushed image/manifest for this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me based on our discussions and my testing
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
I am a bot, here is the pushed image/manifest for this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice add with the perf notes
I find that using HTTP3 breaks Authelia (4.39.5) as I can't longer access my services. I find this in Authelia continer log:
Did you guys run into similar while testing? |
I was able to replicate the issue and have brought it up to the authelia team we likely need ppl to test authentik and tinyauth as well |
I think it's possible to circumvent the issue by some headers magic( |
Going to merge this as QUIC is not enabled by default so isn't going to break existing setups, but we'll keep an eye on the 3rd party auth providers. |
A similar situation exists with Authentik. This occurs quite randomly and manifests itself in URL truncation during redirection after authorization. |
authelia team stated they dont even support http2 and havent tested 3 at all. They claimed that traefik doesn't have this issue thread begins here https://discord.com/channels/707844280412012608/707844280412012612/1396194429899112631 |
I was under impression that Authelia doesn't care about HTTP protocols as nginx deals with that on a layer above it. Perhaps we could use 1.1 just for authelia if that matters? |
i havent dug much into it personally, if you are going to dig in, please do and let us know what changes we can make to better support. I appreciate all your help thus far (especially with identifying the issue to begin with) |
I was getting the same error, and I think I was able to fix this by changing I don't know if this is correct, but everywhere else in proxy.conf has |
Further searching led to this previous discussion from authelia on the topic of missing
|
A thing came to my mind, what if all proxy confs had quic but just authelia had ssl listener? |
give it a shot and see, then let us know! |
I found that actually using both quic+ssl listeners helped somewhat but not entirely for all apps:
|
Description:
Benefits of this PR and context:
How Has This Been Tested?
Source / References: