Added Lenovo Yoga 7 pen and tablet #949
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds configuration support for the Lenovo Yoga 7 14AKP10 pen and tablet device by introducing a new tablet definition file and a corresponding stylus definition entry.
- Adds stylus definition for Lenovo Yoga Pen (ID 0x8113) in wacom.stylus
- Adds tablet configuration file for Lenovo Wacom 53FD (device ID i2c:056a:53fd)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| data/wacom.stylus | Adds a new stylus definition entry for the Lenovo Yoga Pen with tilt and pressure support, 2 buttons, and Mobile type classification |
| data/lenovo-wacom-53fd.tablet | Creates new tablet configuration file for Lenovo Yoga 7 14AKP10 with device dimensions (12"x7"), i2c interface matching, and references to both isdv4-aes group and the specific 0x8113 stylus |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PairedStylusIds=0x56a:0x10002; | ||
| AliasOf=0x56a:0x100a | ||
|
|
||
| [0x8113] |
There was a problem hiding this comment.
The stylus ID section header format is inconsistent with all other entries in this file. All other stylus definitions in wacom.stylus use the vendor:product format (e.g., [0x56a:0x1], [0x56a:0x842]), but this entry uses only the product ID without the vendor prefix. This should likely be [0x56a:0x8113] to match the established pattern, where 0x56a is the Wacom vendor ID.
| [0x8113] | |
| [0x56a:0x8113] |
There was a problem hiding this comment.
huh, apparently copilot is enabled here now. Anyway, it's correct with this comment, you need a vid:pid format for the pen now and the vid has to effectively match the tablet's vid.
| Name=Lenovo Yoga Pen (0x8113) | ||
| Group=isdv4-aes | ||
| Buttons=2 | ||
| Axes=Tilt;Pressure; |
There was a problem hiding this comment.
The trailing semicolon in the Axes field is inconsistent with the pattern used elsewhere in this file. When the Axes list ends with the last axis (no more axes follow), there should be no trailing semicolon. Other entries with just Tilt and Pressure (e.g., lines 111, 118, 125, 132, 136, 141) use Axes=Tilt;Pressure without a trailing semicolon.
| Axes=Tilt;Pressure; | |
| Axes=Tilt;Pressure |
| Width=12 | ||
| Height=7 | ||
| IntegratedIn=Display;System | ||
| Styli=@isdv4-aes;0x8113; |
There was a problem hiding this comment.
I'm wondering about the compatibility of that pen, my gut feeling tells me this one should be wacom-compatible and thus part of the @isdv4-aes group. @jigpu?
2 participants
No description provided.